open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

Continue updating deployment manifests when uninstalling #226

Closed mprahl closed 11 months ago

mprahl commented 11 months ago

This allows an addon to update its deployment manifests while the predelete hook is running. This is useful when telling the addon to enter uninstall mode.

Additionally, if there is a bug in the uninstall and it keeps the uninstall from succeeding, we need to allow container image updates to move forward in the event the update fixes the problem.

Relates: https://issues.redhat.com/browse/ACM-8947

mprahl commented 11 months ago

/cc @JustinKuli

mprahl commented 11 months ago

/hold if you agree with the approach, I'll work to get the tests working

zhiweiyin318 commented 11 months ago

/LGTM the manifestworks should not be re-created when cluster/addon is deleting, it is ok for me in this pre-delete case. cc @qiujian16 @zhujian7

mprahl commented 11 months ago

/unhold this is ready for review with the tests fixed

mprahl commented 11 months ago

/cc @zhujian7

zhujian7 commented 11 months ago

/lgtm

mprahl commented 11 months ago

@zhiweiyin318 could you please take another look?

zhiweiyin318 commented 11 months ago

/LGTM need approve from @qiujian16

qiujian16 commented 11 months ago

/approve

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mprahl commented 11 months ago

/unhold