Closed mprahl closed 11 months ago
/cc @JustinKuli
/hold if you agree with the approach, I'll work to get the tests working
/LGTM the manifestworks should not be re-created when cluster/addon is deleting, it is ok for me in this pre-delete case. cc @qiujian16 @zhujian7
/unhold this is ready for review with the tests fixed
/cc @zhujian7
/lgtm
@zhiweiyin318 could you please take another look?
/LGTM need approve from @qiujian16
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mprahl, qiujian16
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/unhold
This allows an addon to update its deployment manifests while the predelete hook is running. This is useful when telling the addon to enter uninstall mode.
Additionally, if there is a bug in the uninstall and it keeps the uninstall from succeeding, we need to allow container image updates to move forward in the event the update fixes the problem.
Relates: https://issues.redhat.com/browse/ACM-8947