search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

🐛 Do not check addon status when the cluster availability is unknown #229

Closed zhujian7 closed 10 months ago

zhujian7 commented 10 months ago

Do not check addon status when the cluster availability is unknown, otherwise, when the cluster is unknown and the manifestwork feedback rule deployment available replica >1(was not updated after the cluster is unknown), the addon-framework will update the addon status to True, but the registration-agent will update the addon status to Unknown, which will lead to an infinite loop

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [zhujian7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhujian7 commented 10 months ago

@qiujian16 @zhiweiyin318

qiujian16 commented 10 months ago

/lgtm