search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

fix the pre-delete hook is recreated in hosted mode #231

Closed zhiweiyin318 closed 9 months ago

zhiweiyin318 commented 9 months ago

/assign @qiujian16 /assign @zhujian7

zhiweiyin318 commented 9 months ago

I think you need to add an integration test. e.g. add another finalizer to pend the addon deletion, and check if manifestwork recreation.

@qiujian16 have added.

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16,zhiweiyin318] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qiujian16 commented 9 months ago

leave to @zhujian7 for final review

zhujian7 commented 9 months ago

/lgtm