open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

🌱 Start ocm env using clusteradm #254

Closed qiujian16 closed 7 months ago

qiujian16 commented 7 months ago

Summary

Related issue(s)

Fixes #

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qiujian16 commented 7 months ago

/assign @zhujian7

zhiweiyin318 commented 7 months ago

/lgtm

zhiweiyin318 commented 7 months ago

/lgtm

zhujian7 commented 7 months ago

/lgtm

zhujian7 commented 7 months ago

@dhaiducek @mprahl FYI: I know there seems to be a policy repo that uses the cloning ocm repo and executing make commands to install an ocm env, which is error-prone, here is an example of using the clusteradm to set up an ocm env for your reference, hope this is helpful.

dhaiducek commented 7 months ago

@zhujian7 Thanks for tagging us! clusteradm could be a good solution and we'd definitely be on board for a more reliable build, but for our use-cases:

Would both of these be straightforward with clusteradm also?

zhujian7 commented 7 months ago

@dhaiducek I am not quite sure if this is what you need, but you can have a try. there are --bundle-version='xx' and --image-registry='xxx' options for the clusteradm init and clusteradm join commands.