search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

✨ support config work driver. #256

Closed morvencao closed 5 months ago

morvencao commented 6 months ago

Summary

This PR aims to enhance the addon-manager by adding work driver configuration support. This enables the addon manager to deploy addon agents using drivers other than kube.

Related issue(s)

ref: https://issues.redhat.com/browse/ACM-10423

morvencao commented 6 months ago

/hold

morvencao commented 6 months ago

/assign @qiujian16 @skeeey

qiujian16 commented 5 months ago

@zhujian7 @zhiweiyin318 pls take a careful look at this one, to avoid any compatibility issue

morvencao commented 5 months ago

kindly ping @zhujian7 @zhiweiyin318 ~

zhiweiyin318 commented 5 months ago

Look good to me.

morvencao commented 5 months ago

@qiujian16 @zhujian7 Another look?

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: morvencao, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
morvencao commented 5 months ago

added back the e2e testing for helloworld addon using cloudevents. /unhold

@zhujian7 PTAL

zhujian7 commented 5 months ago

LGTM

zhujian7 commented 5 months ago

/lgtm