search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

:book: Update readme with addon contributions link #266

Closed mikeshng closed 4 months ago

mikeshng commented 4 months ago

Summary

Update the README with addon contribution repo link

Related issue(s)

Fixes #

mikeshng commented 4 months ago

Doc update like this one should not trigger e2e. Did I not do something in the PR?

xuezhaojun commented 4 months ago

Doc update like this one should not trigger e2e. Did I not do something in the PR?

No, I met the same e2e which should not occur, it seems like some thiing addon-framework e2e depends on changed, for example the images it use or the clusteradmin.

mikeshng commented 4 months ago

Doc update like this one should not trigger e2e. Did I not do something in the PR?

No, I met the same e2e which should not occur, it seems like some thiing addon-framework e2e depends on changed, for example the images it use or the clusteradmin.

Thanks and go to sleep :sweat_smile:

xuezhaojun commented 4 months ago

/lgtm

zhujian7 commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [zhujian7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment