open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

🐛 read config referent from the desired config #269

Closed qiujian16 closed 5 months ago

qiujian16 commented 6 months ago

Summary

Related issue(s)

Fixes #

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qiujian16 commented 5 months ago

/cherry-pick release-0.9

openshift-cherrypick-robot commented 5 months ago

@qiujian16: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to [this](https://github.com/open-cluster-management-io/addon-framework/pull/269#issuecomment-2119545947): >/cherry-pick release-0.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
zhujian7 commented 5 months ago

/lgtm

openshift-cherrypick-robot commented 5 months ago

@qiujian16: new pull request created: #271

In response to [this](https://github.com/open-cluster-management-io/addon-framework/pull/269#issuecomment-2119545947): >/cherry-pick release-0.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.