Open MikeSpreitzer opened 5 months ago
https://github.com/open-cluster-management-io/addon-framework/blob/main/examples/helloworld/manifests/templates/deployment.yaml references some values that are not explained in the documentation and, I suspect, may be outdated.
In that template I see the following mysterious value references.
.Tolerations
.NodeSelector
.HTTPProxy
.HTTPSProxy
.NoProxy
Looking in https://github.com/open-cluster-management-io/addon-framework/blob/main/pkg/addonfactory/addondeploymentconfig.go I found ToAddOnNodePlacementValues and ToAddOnProxyConfigValues. These support the following references from a template.
.tolerations
.global.nodeSelector
.global.proxyConfig.HTTP_PROXY
.global.proxyConfig.HTTPS_PROXY
.global.proxyConfig.NO_PROXY
They also support .global.proxyConfig.PROXY_CA_BUNDLE but the example template does not use anything like that.
.global.proxyConfig.PROXY_CA_BUNDLE
I also found ToAddOnDeloymentConfigValues, which provides values named Tolerations and NodeSelector but nothing for proxy config. This function is not mentioned in https://open-cluster-management.io/developer-guides/addon/ .
ToAddOnDeloymentConfigValues
Tolerations
NodeSelector
cc @zhujian7
qiujian16
commented
5 months ago qiujian16
commented
5 months ago
https://github.com/open-cluster-management-io/addon-framework/blob/main/examples/helloworld/manifests/templates/deployment.yaml references some values that are not explained in the documentation and, I suspect, may be outdated.
In that template I see the following mysterious value references.
.Tolerations.NodeSelector.HTTPProxy.HTTPSProxy.NoProxyLooking in https://github.com/open-cluster-management-io/addon-framework/blob/main/pkg/addonfactory/addondeploymentconfig.go I found ToAddOnNodePlacementValues and ToAddOnProxyConfigValues. These support the following references from a template.
.tolerations.global.nodeSelector.global.proxyConfig.HTTP_PROXY.global.proxyConfig.HTTPS_PROXY.global.proxyConfig.NO_PROXYThey also support
.global.proxyConfig.PROXY_CA_BUNDLEbut the example template does not use anything like that.I also found
ToAddOnDeloymentConfigValues, which provides values namedTolerationsandNodeSelectorbut nothing for proxy config. This function is not mentioned in https://open-cluster-management.io/developer-guides/addon/ .