search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

:seedling: refactor basecontroller with sdk-go and move certrotation to sdk-go #277

Closed zhiweiyin318 closed 4 months ago

zhiweiyin318 commented 4 months ago

Summary

Related issue(s)

Fixes # https://github.com/open-cluster-management-io/addon-framework/issues/276

zhiweiyin318 commented 4 months ago

we should also remove be basecontroller or mark them as deprecated.

@qiujian16 yes, basecontroller has been removed too.

qiujian16 commented 4 months ago

/approve /lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16,zhiweiyin318] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment