search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

🐛 Skip health check for deployments whose replicas is 0 #279

Closed zhujian7 closed 2 months ago

zhujian7 commented 2 months ago

Summary

In some cases, we want to deploy a deployment resource whose replicas is 0 to the managed cluster, if we set the health probe type to "WorkloadAvailability", the addon can not become available since there is no probed result for 0 replicas deployments. In this situation, we want to make the health probe check pass for the addon.

Related issue(s)

Fixes #

zhujian7 commented 2 months ago

/hold

zhujian7 commented 2 months ago

/hold cancel /cc @qiujian16

zhujian7 commented 2 months ago

/cherrypick release-0.10

openshift-cherrypick-robot commented 2 months ago

@zhujian7: once the present PR merges, I will cherry-pick it on top of release-0.10 in a new PR and assign it to you.

In response to [this](https://github.com/open-cluster-management-io/addon-framework/pull/279#issuecomment-2205495095): >/cherrypick release-0.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
qiujian16 commented 2 months ago

/approve /lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16,zhujian7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 2 months ago

@zhujian7: new pull request created: #280

In response to [this](https://github.com/open-cluster-management-io/addon-framework/pull/279#issuecomment-2205495095): >/cherrypick release-0.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.