search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

add certrotation from registration-operator to addon-framework #42

Closed xuezhaojun closed 3 years ago

xuezhaojun commented 3 years ago

Signed-off-by: xuezhaojun zxue@redhat.com

xuezhaojun commented 3 years ago

/assign @qiujian16

xuezhaojun commented 3 years ago

@yue9944882 Hello Kim, Thanks for the view. This new add pkg is actually a copy from registration-operator certrotation. The motivation is we are working on some addons needs this feature and currently they leverage certroatation from registration-operator directly and it's not a proper way to do this.

So the first idea I come up with is to move this pkg to addon-framework to eliminate the dependency of registration-operator. But I haven't gone to the details yet honestly so I may not enable to answer all question immediately.

I can use a couple of days to comprehend this pkg and then answers the above questions more accurately. Meanwhile, welcome any new ideas, requirements or designs for this feature.

xuezhaojun commented 3 years ago

Hello, @qiujian16 @yue9944882 I have replied to the comments, I think we can collect more use cases from addons in the future and do a refactor then.

yue9944882 commented 3 years ago

@qiujian16 am +1 to get this merged in the current phase, hopefully i will be getting back w/ more feedbacks after rebasing our addons onto it.

qiujian16 commented 3 years ago

/approve /lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment