search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

Add csr helpers func #59

Closed qiujian16 closed 2 years ago

qiujian16 commented 2 years ago

Signed-off-by: Jian Qiu jqiu@redhat.com

qiujian16 commented 2 years ago

/hold still need to add unit test

qiujian16 commented 2 years ago

/assign @yue9944882 /assign @xuezhaojun

xuezhaojun commented 2 years ago

/approve Looks good to me.

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/addon-framework/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xuezhaojun commented 2 years ago

/lgtm

qiujian16 commented 2 years ago

/unhold