search

open-cluster-management-io / addon-framework

addon apis
Apache License 2.0
23 stars 40 forks source link

Support change `installNamespace` of agent addons. #92

Closed xuezhaojun closed 2 years ago

xuezhaojun commented 2 years ago

Currently, the agent addon is installed in ns open-cluster-management-agent-addon by default.

If a user is using the WithInstallStrategy function, then the installNamespace is unchangeable.

Could we provide a way to support user change installNamespace of agent addon in running time?

qiujian16 commented 2 years ago

this is fixed in framework. The framework only create the addon if it does not exist now.

/close

openshift-ci[bot] commented 2 years ago

@qiujian16: Closing this issue.

In response to [this](https://github.com/open-cluster-management-io/addon-framework/issues/92#issuecomment-1177089220): >this is fixed in framework. The framework only create the addon if it does not exist now. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.