search

open-cluster-management-io / api

Core APIs for open cluster management
https://open-cluster-management.io
Apache License 2.0
251 stars 77 forks source link

🐛 support update&updateStatus for manifestwork cloudevents client. #279

Closed morvencao closed 1 year ago

morvencao commented 1 year ago

Summary

This PR introduces the addition of 'Update' and 'UpdateStatus' functionalities for the manifestwork cloudevents client. These methods are necessary as the work-client implementation will use them, but currently the manifestwork cloudevents client only includes 'Get' and 'Patch'.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: morvencao Once this PR has been reviewed and has the lgtm label, please assign qiujian16 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/open-cluster-management-io/api/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
morvencao commented 1 year ago

/assign @skeeey

skeeey commented 1 year ago

@morvencao the newest work-agent in ocm only use patch way to update mw or it's status, this is why we only implement the patch way for the agent mw client :)

morvencao commented 1 year ago

/hold

morvencao commented 1 year ago

closing this as the new work-agent only needs patch.