search

open-cluster-management-io / api

Core APIs for open cluster management
https://open-cluster-management.io
Apache License 2.0
251 stars 77 forks source link

:sparkles: Add flag to allow use best effort resource for klusterlet #297

Closed haowells closed 12 months ago

haowells commented 12 months ago

Summary

see PR in https://github.com/open-cluster-management-io/ocm/pull/317

Related issue(s)

Fixes #

mikeshng commented 12 months ago

/assign @qiujian16

qiujian16 commented 12 months ago

would need to run make update to update deepcopy and client code

qiujian16 commented 12 months ago

need to signoff. And you would need to run make update again.

haowells commented 12 months ago

/ok-to-test

openshift-ci[bot] commented 12 months ago

@haowells: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/open-cluster-management-io/api/pull/297#issuecomment-1825362849): >/ok-to-test > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
haowells commented 12 months ago

/test all

openshift-ci[bot] commented 12 months ago

@haowells: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/open-cluster-management-io/api/pull/297#issuecomment-1825363623): >/test all Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qiujian16 commented 12 months ago

/approve /lgtm

openshift-ci[bot] commented 12 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haowells, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/api/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qiujian16 commented 12 months ago

/lgtm