open-cluster-management-io / api

Core APIs for open cluster management
https://open-cluster-management.io
Apache License 2.0
251 stars 77 forks source link

✨ Configurable qos resources for deployments managed by clustermanager and klusterlet #316

Closed dongbeiqing91 closed 10 months ago

dongbeiqing91 commented 10 months ago

Summary

Support configurable qos resources for deployments managed by clustermanager and klusterlet because "Default" deployment resources w/ only hard coded "resources" but no "limits" is not good enough and "BestEffort" is usually not allowed in production.

Related issue(s)

Fixes #

dongbeiqing91 commented 10 months ago

/assign @qiujian16

zhiweiyin318 commented 10 months ago

the deepcopy go file is not updated, is there any error durning running the make update?

dongbeiqing91 commented 10 months ago

the deepcopy go file is not updated, is there any error durning running the make update?

It indeeded had some errors I didn't pay attention to. Let me check and fix it

dongbeiqing91 commented 10 months ago

the deepcopy go file is not updated, is there any error durning running the make update?

The project path was wrong. I have fixed it. deepcopy is correctly generated now.

zhiweiyin318 commented 10 months ago

the DCO Check requires a Signed-off-by trailer in the commit log. so you need to add -s when run git commit.

dongbeiqing91 commented 10 months ago

the DCO Check requires a Signed-off-by trailer in the commit log. so you need to add -s when run git commit.

Done

qiujian16 commented 10 months ago

/approve /lgtm

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: promid, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/api/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment