Closed dongbeiqing91 closed 10 months ago
/assign @qiujian16
the deepcopy go file is not updated, is there any error durning running the make update
?
the deepcopy go file is not updated, is there any error durning running the
make update
?
It indeeded had some errors I didn't pay attention to. Let me check and fix it
the deepcopy go file is not updated, is there any error durning running the
make update
?
The project path was wrong. I have fixed it. deepcopy is correctly generated now.
the DCO Check requires a Signed-off-by trailer in the commit log. so you need to add -s
when run git commit
.
the DCO Check requires a Signed-off-by trailer in the commit log. so you need to add
-s
when rungit commit
.
Done
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: promid, qiujian16
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Summary
Support configurable qos resources for deployments managed by clustermanager and klusterlet because "Default" deployment resources w/ only hard coded "resources" but no "limits" is not good enough and "BestEffort" is usually not allowed in production.
Related issue(s)
Fixes #