search

open-cluster-management-io / api

Core APIs for open cluster management
https://open-cluster-management.io
Apache License 2.0
251 stars 77 forks source link

🌱 Regenerate informers with WithTransform #320

Closed skitt closed 9 months ago

skitt commented 9 months ago

Summary

Since 1.29, Kubernetes supports transforming informers, which is useful to reduce the amount of memory used by the underlying caches. This updates the code generator to the latest 0.29 release and re-generates the informers.

Related issue(s)

Fixes #

dfarrell07 commented 9 months ago

/lgtm

vthapar commented 9 months ago

Can we get review on this? This will be very helpful for optimization work we're doing on SubmarinerAddon.

mikeshng commented 9 months ago

/assign @qiujian16

qiujian16 commented 9 months ago

would you run go mod tidy and go mod vendor?

skitt commented 9 months ago

would you run go mod tidy and go mod vendor?

I’d already done that, the verify-deps failure happened because CI was set up for Go 1.20 and the build now requires 1.21.

qiujian16 commented 9 months ago

/approve /lgtm

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/api/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment