open-cluster-management-io / api

Core APIs for open cluster management
https://open-cluster-management.io
Apache License 2.0
251 stars 77 forks source link

:sparkles: Aws iam auth api change request #339

Closed suvaanshkumar closed 2 months ago

suvaanshkumar commented 2 months ago

Summary

Related issue(s)

Fixes #

qiujian16 commented 2 months ago

you would need to update the types.go at first, and then run make update to generate crd and client code. Ensure to run make verify after make update. Here https://github.com/open-cluster-management-io/api/blob/main/docs/development.md has some infos.

EricaJ6 commented 2 months ago

Thanks @qiujian16 for the suggestions. Please take a look at the updated changes with required changes.

qiujian16 commented 2 months ago

/approve

@mikeshng @elgnay would you take the review and tag?

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, suvaanshkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/api/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elgnay commented 2 months ago

LGTM

qiujian16 commented 2 months ago

/lgtm