search

open-cluster-management-io / cluster-proxy

An OCM addon that automates the installation of Kubernetes' konnectivity servers and agents.
Apache License 2.0
45 stars 22 forks source link

Add nodePlacement for agent #125

Closed xuezhaojun closed 2 years ago

xuezhaojun commented 2 years ago

Signed-off-by: xuezhaojun zxue@redhat.com

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xuezhaojun Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval by writing /assign @yue9944882 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/open-cluster-management-io/cluster-proxy/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xuezhaojun Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval by writing /assign @yue9944882 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/open-cluster-management-io/cluster-proxy/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xuezhaojun commented 2 years ago

/assign @qiujian16 /assign @yue9944882

xuezhaojun commented 2 years ago

This might be conflict or overlap with https://github.com/open-cluster-management-io/enhancements/pull/58

openshift-merge-robot commented 2 years ago

@xuezhaojun: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.