search

open-cluster-management-io / cluster-proxy

An OCM addon that automates the installation of Kubernetes' konnectivity servers and agents.
Apache License 2.0
45 stars 22 forks source link

add option agentInstallAll, to control if install cluster-proxy addon… #127

Closed ivan-cai closed 2 years ago

ivan-cai commented 2 years ago

… agent to all clusters

sometimes, we do not want install cluster-proxy to all clusters, but there is no this option

ivan-cai commented 2 years ago

@qiujian16 @yue9944882 Plz review

qiujian16 commented 2 years ago

should we also update the helm chart?

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan-cai, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/cluster-proxy/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ivan-cai commented 2 years ago

should we also update the helm chart?

/approve

@qiujian16 Yes, I have updated. And what should I do for e2e?

ivan-cai commented 2 years ago

@yue9944882 Plz review, thx

ivan-cai commented 2 years ago

@qiujian16 @yue9944882 Plz merging this pr. Thx!

qiujian16 commented 2 years ago

/lgtm

qiujian16 commented 2 years ago

sorry, I missed this...