search

open-cluster-management-io / cluster-proxy

An OCM addon that automates the installation of Kubernetes' konnectivity servers and agents.
Apache License 2.0
45 stars 22 forks source link

Customized serviceDomain by addondeploymentconfig is feasible now. #144

Closed xuezhaojun closed 1 year ago

xuezhaojun commented 1 year ago

Signed-off-by: xuezhaojun zxue@redhat.com

Verified with addondeploymentconfig, now customize the serviceDomain is feasible with a new testcase. And also remove TODO in serviceDomain comments.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/cluster-proxy/blob/main/OWNERS)~~ [xuezhaojun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xuezhaojun commented 1 year ago

/assign @qiujian16 /assign @skeeey /assign @yue9944882

Please take a look when you have time, thanks!

qiujian16 commented 1 year ago

/lgtm