search

open-cluster-management-io / cluster-proxy

An OCM addon that automates the installation of Kubernetes' konnectivity servers and agents.
Apache License 2.0
45 stars 22 forks source link

Fix: add a flag to control whether we need the default kube-apiserver proxy. #148

Closed xuezhaojun closed 1 year ago

xuezhaojun commented 1 year ago

Signed-off-by: xuezhaojun zxue@redhat.com

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/cluster-proxy/blob/main/OWNERS)~~ [xuezhaojun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xuezhaojun commented 1 year ago

/assign @qiujian16 Hello, all checks look good, please take a review when you have free time, thanks!

xuezhaojun commented 1 year ago

/assign @qiujian16

xuezhaojun commented 1 year ago

should we also update some args in the deployment of the agent?

Yes, in this case, we think we can delete default agentIndentifiters.

qiujian16 commented 1 year ago

/lgtm