search

open-cluster-management-io / cluster-proxy

An OCM addon that automates the installation of Kubernetes' konnectivity servers and agents.
Apache License 2.0
45 stars 22 forks source link

Fix: too many update of rolebinding. #154

Closed xuezhaojun closed 1 year ago

xuezhaojun commented 1 year ago

The related addon-framework code: https://github.com/open-cluster-management-io/addon-framework/blob/9de90ed830ad9f59c0554d0516c548d808fbb053/pkg/utils/permission.go#L265

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/cluster-proxy/blob/main/OWNERS)~~ [xuezhaojun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.81 :warning:

Comparison is base (8dd5b36) 24.12% compared to head (9d89e74) 23.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #154 +/- ## ========================================== - Coverage 24.12% 23.31% -0.81% ========================================== Files 9 9 Lines 1202 1175 -27 ========================================== - Hits 290 274 -16 + Misses 896 885 -11 Partials 16 16 ``` | Flag | Coverage Δ | | |---|---|---| | unit | `23.31% <ø> (-0.81%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [pkg/proxyagent/agent/agent.go](https://codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#diff-cGtnL3Byb3h5YWdlbnQvYWdlbnQvYWdlbnQuZ28=) | `88.59% <ø> (ø)` | | ... and [3 files with indirect coverage changes](https://codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/154/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

xuezhaojun commented 1 year ago

/assign @ldpliu

ldpliu commented 1 year ago

/lgtm