open-cluster-management-io / cluster-proxy

An OCM addon that automates the installation of Kubernetes' konnectivity servers and agents.
Apache License 2.0
42 stars 22 forks source link

Upgrade go.mod open-cluster-management.io api. #167

Closed xuezhaojun closed 1 year ago

xuezhaojun commented 1 year ago

https://github.com/open-cluster-management-io/ocm/issues/67

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/cluster-proxy/blob/main/OWNERS)~~ [xuezhaojun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xuezhaojun commented 1 year ago

/assign @haoqing0110

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 71.42% and no project coverage change.

Comparison is base (366272a) 23.31% compared to head (9c80fdb) 23.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #167 +/- ## ======================================= Coverage 23.31% 23.31% ======================================= Files 9 9 Lines 1175 1175 ======================================= Hits 274 274 Misses 885 885 Partials 16 16 ``` | [Flag](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/167/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/167/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | `23.31% <71.42%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [...yserver/controllers/service\_resolver\_controller.go](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#diff-cGtnL3Byb3h5c2VydmVyL2NvbnRyb2xsZXJzL3NlcnZpY2VfcmVzb2x2ZXJfY29udHJvbGxlci5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/proxyagent/agent/agent.go](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#diff-cGtnL3Byb3h5YWdlbnQvYWdlbnQvYWdlbnQuZ28=) | `88.59% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

haoqing0110 commented 1 year ago

Seems https://github.com/open-cluster-management-io/cluster-proxy/blob/main/hack/crd/cluster/managedclusterset.yaml https://github.com/open-cluster-management-io/cluster-proxy/blob/main/hack/crd/bases/cluster.open-cluster-management.io_managedclustersets.yaml are still using old version crd.

haoqing0110 commented 1 year ago

/lgtm