open-cluster-management-io / cluster-proxy

An OCM addon that automates the installation of Kubernetes' konnectivity servers and agents.
Apache License 2.0
45 stars 22 forks source link

Fix: add finalizer permission to cluster-proxy. #168

Closed xuezhaojun closed 1 year ago

xuezhaojun commented 1 year ago

Fixes: https://github.com/open-cluster-management-io/ocm/issues/230

Error log:

E1008 07:15:14.237293 1 base_controller.go:159] "addon-deploy-controller" controller failed to sync "local-cluster/cluster-proxy", err: Operation cannot be fulfilled on managedclusteraddons.addon.open-cluster-management.io "cluster-proxy": the object has been modified; please apply your changes to the latest version and try again
E1008 07:15:14.247988 1 base_controller.go:159] "addon-deploy-controller" controller failed to sync "local-cluster/cluster-proxy", err: manifestworks.work.open-cluster-management.io "addon-cluster-proxy-deploy-0" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>
E1008
codecov[bot] commented 1 year ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (366272a) 23.31% compared to head (767d2fb) 23.31%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #168 +/- ## ======================================= Coverage 23.31% 23.31% ======================================= Files 9 9 Lines 1175 1175 ======================================= Hits 274 274 Misses 885 885 Partials 16 16 ``` | [Flag](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/168/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | `23.31% <71.42%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [pkg/proxyagent/agent/agent.go](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#diff-cGtnL3Byb3h5YWdlbnQvYWdlbnQvYWdlbnQuZ28=) | `88.59% <100.00%> (ø)` | | | [...yserver/controllers/service\_resolver\_controller.go](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#diff-cGtnL3Byb3h5c2VydmVyL2NvbnRyb2xsZXJzL3NlcnZpY2VfcmVzb2x2ZXJfY29udHJvbGxlci5nbw==) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xuezhaojun commented 1 year ago

/assign @qiujian16

qiujian16 commented 1 year ago

/approve /lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/cluster-proxy/blob/main/OWNERS)~~ [qiujian16,xuezhaojun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment