Closed tamalsaha closed 6 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tamalsaha, xuezhaojun
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Hi, @tamalsaha I noticed the PR seems mean to make cluster-proxy to work with the multicluster-controlplane.
Consulted with @skeeey, in theory it would work, but we didn't have test cases cover this case. The lib problem may not be the only issue you will encounter with.
To better trace and support this case, I created an issue under the multicluster-controlplane repo, please feel free to share any thoughts about this case.
And we are also looking forward to have you sharing in our bi-week community meeting as well!
I noticed the PR seems mean to make cluster-proxy to work with the multicluster-controlplane.
That is not the case. To support mc-cp, somethign like https://github.com/kluster-manager/cluster-proxy/commit/80c0175e2f537617fe354dc258807e98d926b206#diff-d7b9b86f57d39143d10af42c23ca2e978eab4ec299a9288aeb44405c2de09836 will be required.
Switched to Go 1.21
/lgtm
/approve The changes are in general good, the only concern is whether we can upgrade to 1.21 instead of 1.22.