search

open-cluster-management-io / cluster-proxy

An OCM addon that automates the installation of Kubernetes' konnectivity servers and agents.
Apache License 2.0
45 stars 22 forks source link

Use Go 1.22 #176

Closed tamalsaha closed 8 months ago

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tamalsaha Once this PR has been reviewed and has the lgtm label, please assign xuezhaojun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/open-cluster-management-io/cluster-proxy/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xuezhaojun commented 8 months ago

Hi, @tamalsaha Thanks for the submit, since we have discovered same inconsistency in go1.22 https://github.com/open-cluster-management-io/managed-serviceaccount/pull/96#issuecomment-1976620241 , would you mind change to upgrade-to version of this PR to 1.21?

xuezhaojun commented 8 months ago

The go.mod https://github.com/open-cluster-management-io/cluster-proxy/blob/ae20540551aaefc9a0f894795bd688ac6f5727aa/go.mod#L3 may also need to bump up.

tamalsaha commented 8 months ago

The go.mod

https://github.com/open-cluster-management-io/cluster-proxy/blob/ae20540551aaefc9a0f894795bd688ac6f5727aa/go.mod#L3

may also need to bump up.

This is not done until go mod is updated