search

open-cluster-management-io / cluster-proxy

An OCM addon that automates the installation of Kubernetes' konnectivity servers and agents.
Apache License 2.0
45 stars 22 forks source link

Simplify installer watchers #180

Closed tamalsaha closed 8 months ago

tamalsaha commented 8 months ago

There is no real logical change here. I am just using the EnqueueRequestsFromMapFunc method in controller-runtime to simplify the code.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 23.61%. Comparing base (7491951) to head (9a2429e).

Files Patch % Lines
...yserver/controllers/service_resolver_controller.go 0.00% 22 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #180 +/- ## ========================================== - Coverage 23.86% 23.61% -0.26% ========================================== Files 9 9 Lines 1194 1207 +13 ========================================== Hits 285 285 - Misses 892 905 +13 Partials 17 17 ``` | [Flag](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/180/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/open-cluster-management-io/cluster-proxy/pull/180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | `23.61% <0.00%> (-0.26%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

qiujian16 commented 8 months ago

/assign @xuezhaojun

SGTM /approve

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, tamalsaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/cluster-proxy/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xuezhaojun commented 8 months ago

/lgtm