search

open-cluster-management-io / community

open-cluster-management governance material.
https://open-cluster-management.io
Apache License 2.0
62 stars 23 forks source link

Add contribution guidelines for the Policy SIG #147

Closed mprahl closed 2 years ago

mprahl commented 2 years ago

@JustinKuli and @mikeshng could you please also review this?

JustinKuli commented 2 years ago

Seems good to me! I do wonder if a separate document like this is necessary just for the Policy SIG, since we already have CONTRIBUTING files in each repository. But I don't see this being a problem.

mprahl commented 2 years ago

Seems good to me! I do wonder if a separate document like this is necessary just for the Policy SIG, since we already have CONTRIBUTING files in each repository. But I don't see this being a problem.

The idea is that each repository would point to this contributing guide rather than duplicate it in each repository.

mikeshng commented 2 years ago

/approve

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/community/blob/main/OWNERS)~~ [mikeshng] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment