search

open-cluster-management-io / community

open-cluster-management governance material.
https://open-cluster-management.io
Apache License 2.0
61 stars 23 forks source link

Add code review requirements for the Policy SIG #165

Closed mprahl closed 1 year ago

mprahl commented 1 year ago

/cc @ChunxiAlexLuo /cc @dhaiducek /cc @gparvin /cc @JustinKuli /cc @willkutler

mprahl commented 1 year ago

/cc @ChunxiAlexLuo /cc @dhaiducek /cc @gparvin /cc @JustinKuli /cc @willkutler

mikeshng commented 1 year ago

/lgtm

/approve

In a separate PR, I think we can consider adding one or two members of the policy sig to the owner file.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChunxiAlexLuo, gparvin, mikeshng, mprahl, willkutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/community/blob/main/OWNERS)~~ [mikeshng] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment