open-cluster-management-io / multicloud-operators-subscription

Enables multicluster application delivery.
https://open-cluster-management.io/getting-started/integration/app-lifecycle/
Apache License 2.0
44 stars 39 forks source link

Add additional permissions for subscription admin role #368

Closed philipwu08 closed 1 year ago

philipwu08 commented 1 year ago

https://issues.redhat.com/browse/ACM-7147

Need additional permissions for subscription-admin cluster role for users to be able to deploy application from UI.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.08% :tada:

Comparison is base (430c2e5) 54.52% compared to head (b906f89) 54.61%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #368 +/- ## ========================================== + Coverage 54.52% 54.61% +0.08% ========================================== Files 71 71 Lines 14947 14947 ========================================== + Hits 8150 8163 +13 + Misses 5973 5956 -17 - Partials 824 828 +4 ``` | [Flag](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/368/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | `54.61% <ø> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#carryforward-flags-in-the-pull-request-comment) to find out more. [see 4 files with indirect coverage changes](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/368/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

philipwu08 commented 1 year ago

/assign @mikeshng

mikeshng commented 1 year ago

/approve

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, philipwu08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/multicloud-operators-subscription/blob/main/OWNERS)~~ [mikeshng,philipwu08] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment