open-cluster-management-io / multicloud-operators-subscription

Enables multicluster application delivery.
https://open-cluster-management.io/getting-started/integration/app-lifecycle/
Apache License 2.0
44 stars 39 forks source link

Enable Helm for the policy generator #387

Closed dhaiducek closed 9 months ago

dhaiducek commented 9 months ago

ref: https://issues.redhat.com/browse/ACM-9060

/cc @mprahl

mikeshng commented 9 months ago

/approve

please feel free to l g t m whenever

dhaiducek commented 9 months ago

Thanks @mikeshng! Would you re-run the Go / test workflow? I'm not sure why that one would have failed with this change.

mikeshng commented 9 months ago

Test seems to ran fine the last time but the report coverage server had issue. Retrying again.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6cfc950) 55.21% compared to head (1f9061b) 55.48%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #387 +/- ## ========================================== + Coverage 55.21% 55.48% +0.27% ========================================== Files 71 71 Lines 15317 15317 ========================================== + Hits 8457 8499 +42 + Misses 6011 5962 -49 - Partials 849 856 +7 ``` | [Flag](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/387/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | `55.48% <ø> (+0.27%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dhaiducek commented 9 months ago

/cc @JustinKuli @yiraeChristineKim @gparvin

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, gparvin, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/multicloud-operators-subscription/blob/main/OWNERS)~~ [mikeshng] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment