search

open-cluster-management-io / multicloud-operators-subscription

Enables multicluster application delivery.
https://open-cluster-management.io/getting-started/integration/app-lifecycle/
Apache License 2.0
44 stars 39 forks source link

spoke token controller unit test fix along with app addon ns customiz… #398

Closed xiangjingli closed 6 months ago

xiangjingli commented 6 months ago

…ation

The spoke token controller unit test is fixed due to the unit test failure observed in the midstream repo, where the unit test is executed inside of a k8s pod in Prow CI/CD env. Its pod namespace is shared with the unit test job. So the SA in the unit test is actually created in the unit test k8s pod NS.

Though the unit test failure doesn't happen in upstream repo as upstream CI/CD is github workflow rather than the k8s Prow, It is better to merge it back to upstream to keep the code consistency.

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/multicloud-operators-subscription/blob/main/OWNERS)~~ [xiangjingli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.52%. Comparing base (f9dc1e6) to head (085d055).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #398 +/- ## ========================================== + Coverage 56.21% 56.52% +0.30% ========================================== Files 68 68 Lines 15191 15191 ========================================== + Hits 8539 8586 +47 + Misses 5795 5754 -41 + Partials 857 851 -6 ``` | [Flag](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/398/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | `56.52% <ø> (+0.30%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.