search

open-cluster-management-io / multicloud-operators-subscription

Enables multicluster application delivery.
https://open-cluster-management.io/getting-started/integration/app-lifecycle/
Apache License 2.0
44 stars 39 forks source link

App lifecyle CRD api description updates #403

Closed xiangjingli closed 4 months ago

xiangjingli commented 4 months ago

https://issues.redhat.com/browse/ACM-8973

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/multicloud-operators-subscription/blob/main/OWNERS)~~ [xiangjingli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xiangjingli commented 4 months ago

@jc-berger You may just review the following two types.go. The other CRDs are generated files based on the types.go

xiangjingli commented 4 months ago

/test test

openshift-ci[bot] commented 4 months ago

@xiangjingli: No presubmit jobs available for open-cluster-management-io/multicloud-operators-subscription@main

In response to [this](https://github.com/open-cluster-management-io/multicloud-operators-subscription/pull/403#issuecomment-2174738773): >/test test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.62%. Comparing base (1ce18af) to head (ae1d18b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #403 +/- ## ========================================== - Coverage 56.65% 56.62% -0.03% ========================================== Files 68 68 Lines 15207 15207 ========================================== - Hits 8615 8611 -4 - Misses 5729 5736 +7 + Partials 863 860 -3 ``` | [Flag](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/403/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | `56.62% <ø> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.