search

open-cluster-management-io / multicloud-operators-subscription

Enables multicluster application delivery.
https://open-cluster-management.io/getting-started/integration/app-lifecycle/
Apache License 2.0
44 stars 39 forks source link

performance enhacement on 3500 scale test env #404

Closed xiangjingli closed 4 months ago

xiangjingli commented 4 months ago

https://issues.redhat.com/browse/ACM-11338

  1. The appsub status lastUpdateTime won't be updated if there is no status change. This is to reduce the reconcile frequency
  2. List manifestwork with pagination
  3. remove deprecated gopkg.in/src-d/go-git.v4, use its latest github.com/go-git/go-git/v5 to get their newer fixes. There is a issue in go-git when parsing IPV6 address. That caused the channel connection failure to a private gogs server using IPV6 URL
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/multicloud-operators-subscription/blob/main/OWNERS)~~ [xiangjingli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.46%. Comparing base (1ce18af) to head (be5e0b0). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #404 +/- ## ========================================== - Coverage 56.65% 56.46% -0.19% ========================================== Files 68 68 Lines 15207 15223 +16 ========================================== - Hits 8615 8596 -19 - Misses 5729 5776 +47 + Partials 863 851 -12 ``` | [Flag](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/404/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/404/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | `56.46% <ø> (-0.19%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.