search

open-cluster-management-io / multicloud-operators-subscription

Enables multicluster application delivery.
https://open-cluster-management.io/getting-started/integration/app-lifecycle/
Apache License 2.0
44 stars 39 forks source link

Upgrade: Generator to v1.14.0 / Base image to UBI9 #405

Closed dhaiducek closed 4 months ago

dhaiducek commented 4 months ago
dhaiducek commented 4 months ago

Including this in OCM v1.14.0 isn't critical (unless someone in the community asks for it or the UBI9 bump is desired).

I've added the -y flags to microdnf because in ubi9, those commands started blocking without it.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.80%. Comparing base (6f6a8ff) to head (9c2b63a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #405 +/- ## ========================================== + Coverage 56.04% 56.80% +0.76% ========================================== Files 68 68 Lines 15223 15223 ========================================== + Hits 8531 8647 +116 + Misses 5845 5718 -127 - Partials 847 858 +11 ``` | [Flag](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/405/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/405/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | `56.80% <ø> (+0.76%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xiangjingli commented 4 months ago

/lgtm

xiangjingli commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/multicloud-operators-subscription/blob/main/OWNERS)~~ [xiangjingli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment