search

open-cluster-management-io / multicloud-operators-subscription

Enables multicluster application delivery.
https://open-cluster-management.io/getting-started/integration/app-lifecycle/
Apache License 2.0
44 stars 39 forks source link

avoid error status accumulation when failing to fetch hub channel #408

Closed xiangjingli closed 3 months ago

xiangjingli commented 3 months ago

https://issues.redhat.com/browse/ACM-12448

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/multicloud-operators-subscription/blob/main/OWNERS)~~ [xiangjingli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.55%. Comparing base (7ecb081) to head (a694481).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #408 +/- ## ========================================== - Coverage 56.78% 56.55% -0.24% ========================================== Files 68 68 Lines 15243 15243 ========================================== - Hits 8656 8620 -36 - Misses 5725 5770 +45 + Partials 862 853 -9 ``` | [Flag](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/open-cluster-management-io/multicloud-operators-subscription/pull/408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io) | `56.55% <ø> (-0.24%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-cluster-management-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.