open-cluster-management-io / multicluster-controlplane

A standalone controlplane to run ocm core.
Apache License 2.0
15 stars 23 forks source link

CSR is not auto approved when --set enableSelfManagement=true #116

Closed tamalsaha closed 1 year ago

tamalsaha commented 1 year ago

I am installing mc-cp with --set enableSelfManagement=true. The CSR for the self cluster is created but is not auto approved. If I manually approve the csr, everything seem to work as expected.

clyang82 commented 1 year ago

Did you have https://github.com/open-cluster-management-io/multicluster-controlplane/blob/65996596b295e0e438f198eb728d0ebf7e449927/charts/multicluster-controlplane/values.yaml#L10 enabled in your environment?

tamalsaha commented 1 year ago

Yes, I am using the ManagedClusterAutoApproval=true feature flag but I am still seeing it.

Screenshot 2023-08-24 at 4 16 00 PM
skeeey commented 1 year ago

I think you also need set autoApprovalBootstrapUsers=system:admin when you enable the self management, e.g

--set enableSelfManagement=true
--set autoApprovalBootstrapUsers=system:admin
tamalsaha commented 1 year ago

Thanks. This solved the issue.