open-cluster-management-io / open-cluster-management-io.github.io

Website code for https://open-cluster-management.io/
https://open-cluster-management.io/
Apache License 2.0
16 stars 68 forks source link

bug report: clipboard-copy function #168

Open ycyaoxdu opened 2 years ago

ycyaoxdu commented 2 years ago

While using the copy function for coping the code snippet, I found it doesn't works properly:

When i clicked the copy of step 2 code snippet 1 here, what i get in my clipboard is :

$ kubectl -n open-cluster-management   get pod   --context ${CTX_HUB_CLUSTER}
NAME                               READY   STATUS    RESTARTS   AGE
cluster-manager-695d945d4d-5dn8k   1/1     Running   0          19d

the non-command lines which don't start with a $ is also been copied.

I'm wondering that if it is ok for just add a judgment rule to the copy function to determine whether the line is stared with $ which means that it is a command should be copied.

qiujian16 commented 2 years ago

/assign @morvencao

morvencao commented 2 years ago

@ycyaoxdu It's not hard to trim the prompt character $, but what about the command output? A better solution IMO would be putting the command itself and command output in different html element.

/enhance

morvencao commented 2 years ago

And also what if we have multiple commands in a code block, for example:

$ echo "Hello" >file.txt
$ cat file.txt
Hello