search

open-cluster-management-io / open-cluster-management-io.github.io

Website code for https://open-cluster-management.io/
https://open-cluster-management.io/
Apache License 2.0
16 stars 68 forks source link

Add rollout strategy and update mwrSet #400

Closed serngawy closed 12 months ago

serngawy commented 12 months ago

/assign @haoqing0110 @qiujian16

haoqing0110 commented 12 months ago

LGTM. I will add more addon + rollout API examples in addon page.

aii-nozomu-oki commented 12 months ago

This is exactly what I wanted to know and I appreciate the attempt to document it. By the way, what does "the successful state" mean? Is it AppliedManifestComplete: true, ResourceAvailable: true, or something else?

aii-nozomu-oki commented 12 months ago

After examining the code, it seems to be determined from ResourcesAvailable: true in status.conditions. That true/false seems to use all of the resourceStatus fields. https://github.com/open-cluster-management-io/ocm/blob/29ffff020fafa88b8fbc898711313bc3eabeb6ef/pkg/work/hub/controllers/manifestworkreplicasetcontroller/manifestworkreplicaset_deploy_reconcile.go#L198 https://github.com/open-cluster-management-io/ocm/blob/29ffff020fafa88b8fbc898711313bc3eabeb6ef/pkg/work/spoke/controllers/statuscontroller/availablestatus_controller.go#L196 https://github.com/open-cluster-management-io/ocm/blob/29ffff020fafa88b8fbc898711313bc3eabeb6ef/pkg/work/spoke/controllers/statuscontroller/availablestatus_controller.go#L133C107-L133C121

It might be a good idea to briefly mention that in the documentation.

serngawy commented 12 months ago

This is exactly what I wanted to know and I appreciate the attempt to document it. By the way, what does "the successful state" mean? Is it AppliedManifestComplete: true, ResourceAvailable: true, or something else?

mentioned "the successful state" in placement as successful state cause the definition is different from one API to another; like for manifestwork successful mean resource is available, for other APIs is something else.

serngawy commented 12 months ago

After examining the code, it seems to be determined from ResourcesAvailable: true in status.conditions. That true/false seems to use all of the resourceStatus fields. https://github.com/open-cluster-management-io/ocm/blob/29ffff020fafa88b8fbc898711313bc3eabeb6ef/pkg/work/hub/controllers/manifestworkreplicasetcontroller/manifestworkreplicaset_deploy_reconcile.go#L198 https://github.com/open-cluster-management-io/ocm/blob/29ffff020fafa88b8fbc898711313bc3eabeb6ef/pkg/work/spoke/controllers/statuscontroller/availablestatus_controller.go#L196 https://github.com/open-cluster-management-io/ocm/blob/29ffff020fafa88b8fbc898711313bc3eabeb6ef/pkg/work/spoke/controllers/statuscontroller/availablestatus_controller.go#L133C107-L133C121

It might be a good idea to briefly mention that in the documentation.

okay will add more info for that in the manifestWorkReplicaSet

qiujian16 commented 12 months ago

/approve /lgtm

openshift-ci[bot] commented 12 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, serngawy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/open-cluster-management-io.github.io/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment