search

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies
Apache License 2.0
29 stars 31 forks source link

Add documentation #10

Closed dhaiducek closed 3 years ago

dhaiducek commented 3 years ago

Addresses

mprahl commented 3 years ago

@dhaiducek could you please use a max line length of say 100 characters? The VSCode "prettier" extension can automate this for you.

dhaiducek commented 3 years ago

Prettier apparently doesn't handle comments to rewrap. I had to install the Rewrap extension, but I think that'll be worth it for all the time it saved just this one time! 🙂

dhaiducek commented 3 years ago

/check-dco

mprahl commented 3 years ago

Prettier apparently doesn't handle comments to rewrap. I had to install the Rewrap extension, but I think that'll be worth it for all the time it saved just this one time!

Cool! Let me know when you push the change with it.

dhaiducek commented 3 years ago

It's already pushed (I had to rebase and force push because of DCO)

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management/policy-generator-plugin/blob/main/OWNERS)~~ [dhaiducek,mprahl] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment