search

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies
Apache License 2.0
29 stars 31 forks source link

Wrap Gatekeeper manifests directly when expander is disabled #113

Closed dhaiducek closed 1 year ago

dhaiducek commented 1 year ago

When informGatekeeperPolicies is set to false, wrap Gatekeeper manifests directly in a Policy rather than in a ConfigurationPolicy.

ref: https://issues.redhat.com/browse/ACM-4438

Additionally, I've noticed some cases where a Policy was being wrapped in a Policy by the generator, causing confusion. I added a commit here to throw an error in this case.

mprahl commented 1 year ago

/hold for comment

dhaiducek commented 1 year ago

/unhold

dhaiducek commented 1 year ago

Sorry for the churn--for some reason Tide couldn't rebase, so I rebased it myself.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/policy-generator-plugin/blob/main/OWNERS)~~ [dhaiducek,mprahl] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment