search

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies
Apache License 2.0
29 stars 31 forks source link

RFE: Add version information #118

Closed gnunn1 closed 1 year ago

gnunn1 commented 1 year ago

I have the opensource policygenerator on my system but running into an incompatibility with v2.7 of the ACM version. There doesn't seem to be any way to get it to output it's version?

dhaiducek commented 1 year ago

Thanks for the RFE, @gnunn1! Indeed we don't currently have version information embedded, so this would be a great addition!

dhaiducek commented 1 year ago

@gnunn1 I've implemented a --version flag for the binary but the way it's pulled into the subscription container it won't work. I'll need to follow it up with an additional PR.

dhaiducek commented 1 year ago

Sorry for the noise--on further investigation the implementation will work, with some adjustments to the AppSub generator build.

dhaiducek commented 1 year ago

The build adjustments have been made! The one lingering issue is that using go install doesn't properly return a versioned binary (which seems to be a known issue for Go binaries), but downloading the binary from a release here or using make build-binary will return a versioned binary and the binary in the AppSub container is versioned.

gnunn1 commented 1 year ago

Thanks for your work on this Dale!