search

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies
Apache License 2.0
29 stars 31 forks source link

Add clusterSelector exist operator for empty key value #21

Closed serngawy closed 3 years ago

serngawy commented 3 years ago

Add .idea path to gitignore

Signed-off-by: melserngawy melserng@redhat.com

mprahl commented 3 years ago

@serngawy the change looks good. Could you please add a unit test for this? It should be pretty much copying one that's already there or expanding one that's already there.

serngawy commented 3 years ago

@serngawy the change looks good. Could you please add a unit test for this? It should be pretty much copying one that's already there or expanding one that's already there.

done, extend existing unit test

mprahl commented 3 years ago

@serngawy could you please fix the linting error and disable the one I mentioned in the comment?

mprahl commented 3 years ago

@serngawy my suggestion didn't work for that linter. Try just adding it here: https://github.com/open-cluster-management/policy-generator-plugin/blob/2b6a2271e4de0b1774149782643069a41c246e62/build/common/config/.golangci.yml#L29

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl, serngawy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management/policy-generator-plugin/blob/main/OWNERS)~~ [mprahl] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment