Closed serngawy closed 3 years ago
@serngawy the change looks good. Could you please add a unit test for this? It should be pretty much copying one that's already there or expanding one that's already there.
@serngawy the change looks good. Could you please add a unit test for this? It should be pretty much copying one that's already there or expanding one that's already there.
done, extend existing unit test
@serngawy could you please fix the linting error and disable the one I mentioned in the comment?
@serngawy my suggestion didn't work for that linter. Try just adding it here: https://github.com/open-cluster-management/policy-generator-plugin/blob/2b6a2271e4de0b1774149782643069a41c246e62/build/common/config/.golangci.yml#L29
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mprahl, serngawy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Add .idea path to gitignore
Signed-off-by: melserngawy melserng@redhat.com