Implement the Placement API

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies

Apache License 2.0

29 stars 31 forks source link

Implement the Placement API #30

Closed dhaiducek closed 2 years ago

dhaiducek commented 2 years ago

Sync changes from:

https://github.com/open-cluster-management-io/ocm-kustomize-generator-plugins/pull/3

Addresses:

https://github.com/open-cluster-management/backlog/issues/16319

I may need to look at it more in-depth to make sure the logic flows work, but I think it boils down to this one-line change that did it (it was formerly checking for plCount.plr != 0), and it appears to work:

p.usingPlR = plCount.plc == 0

dhaiducek commented 2 years ago

/hold for reviews/verification

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management/policy-generator-plugin/blob/main/OWNERS)~~ [dhaiducek,mprahl] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

dhaiducek commented 2 years ago

/unhold