search

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies
Apache License 2.0
29 stars 31 forks source link

Add placement generation for policy sets #34

Closed ycao56 closed 2 years ago

ycao56 commented 2 years ago

https://github.com/stolostron/backlog/issues/19413 Refactor createPlacement and createPlacementBinding methods to generate placement and placement binding when policy sets are defined.

Signed-off-by: Yu Cao ycao@redhat.com

ycao56 commented 2 years ago

/hold

mprahl commented 2 years ago

@ycao56 let me know when you've fixed the typos.

ycao56 commented 2 years ago

@mprahl fixed.

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl, ycao56

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/policy-generator-plugin/blob/main/OWNERS)~~ [mprahl,ycao56] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ycao56 commented 2 years ago

/unhold