Add support for policyDefaults.disabled

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies

Apache License 2.0

29 stars 31 forks source link

Add support for policyDefaults.disabled #48

Closed willkutler closed 2 years ago

willkutler commented 2 years ago

Signed-off-by: Will Kutler wkutler@redhat.com

https://github.com/stolostron/backlog/issues/22350

mprahl commented 2 years ago

@willkutler actually, the disabled isn't available under policyDefaults.

To add it, you'll need to do the following:

Add the Disabled field to this struct https://github.com/stolostron/policy-generator-plugin/blob/a26a18edfef92b6127e9d0c355b62bc0eb814a1d/internal/types/types.go#L56
Apply the policyDefault.disabled value on each policy that doesn't set it in the applyDefaults method: https://github.com/stolostron/policy-generator-plugin/blob/a26a18edfef92b6127e9d0c355b62bc0eb814a1d/internal/plugin.go#L314
Use the helper function getPolicyBool to ensure that an explicit false wasn't set on the policy.Disabled before setting the default.

willkutler commented 2 years ago

@mprahl @dhaiducek thanks for the help - does my recent commit look ok?

mprahl commented 2 years ago

@willkutler this looks great! Could you please squash your commits and change the commit message to something like "Add support for policyDefaults.disabled"?

willkutler commented 2 years ago

@mprahl done! thanks for the reviews

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl, willkutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/policy-generator-plugin/blob/main/OWNERS)~~ [mprahl,willkutler] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment