search

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies
Apache License 2.0
29 stars 31 forks source link

Add ability to specify the name of an existing Placement or PlacementRule #51

Closed brian-jarvis closed 2 years ago

brian-jarvis commented 2 years ago

This allows managing all Placements/PlacementRules in the ACM hub separate from the generated policies that use them.

Fixes #50

Example usage available at https://github.com/brian-jarvis/test-placement/tree/reuse-placement

Signed-off-by: Brian Jarvis bjarvis@redhat.com

mprahl commented 2 years ago

@brian-jarvis could you also please squash all of your commits to a single commit message of Add ability to specify the name of an existing Placement or PlacementRule?

mprahl commented 2 years ago

@brian-jarvis could you please fix the linting error?

brian-jarvis commented 2 years ago

@brian-jarvis could you please fix the linting error?

Fixed.

dhaiducek commented 2 years ago

/unhold

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brian-jarvis, dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/policy-generator-plugin/blob/main/OWNERS)~~ [dhaiducek,mprahl] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment