search

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies
Apache License 2.0
29 stars 31 forks source link

validate resource names for dns compliance #63

Closed willkutler closed 2 years ago

willkutler commented 2 years ago

Signed-off-by: Will Kutler wkutler@redhat.com

https://github.com/stolostron/backlog/issues/17598

mprahl commented 2 years ago

@willkutler could you also please squash your commits since there is only one "logical" change in the PR?

willkutler commented 2 years ago

@willkutler could you also please squash your commits since there is only one "logical" change in the PR?

@mprahl I was waiting until review to squash so I could add any extra fixes. I added fixes based off your comments so if it looks good to you now I'll squash it.

mprahl commented 2 years ago

/hold for squash

willkutler commented 2 years ago

@mprahl ready for another review

willkutler commented 2 years ago

/cc @mprahl

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

47.1% 47.1% Coverage
0.0% 0.0% Duplication

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl, willkutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/policy-generator-plugin/blob/main/OWNERS)~~ [mprahl,willkutler] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
willkutler commented 2 years ago

/unhold