Closed dhaiducek closed 2 years ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/hold for reviews and #66
One concern that had come up from us calling kustomize from our plugin (which is itself called from kustomize) was "what if one of the kustomizations we try to use ends up calling another plugin, and we get into a loop that kustomize can't recognize?" (Note that @dhaiducek reported that kustomize will notice if kustomization.yaml files end up calling each other in a loop). We shouldn't need to worry about that - no plugins can be called without enabling alpha plugins explicitly. See https://kubectl.docs.kubernetes.io/guides/extending_kustomize/#required-alpha-flags
Based on the above doc, the only plugins that would be able to run in the ACM application environment is ones that are specially installed (like this plugin). No "in-repo" exec plugins would be able to run without the --enable-exec
flag, and container plugins would likely not be able to run without a container runtime.
Kudos, SonarCloud Quality Gate passed!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dhaiducek, JustinKuli, mprahl
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/unhold
Addresses: